Skip to content

P2278R4: views::as_const#3234

Merged
StephanTLavavej merged 8 commits intomicrosoft:mainfrom
JMazurkiewicz:as_const_view
Dec 15, 2022
Merged

P2278R4: views::as_const#3234
StephanTLavavej merged 8 commits intomicrosoft:mainfrom
JMazurkiewicz:as_const_view

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Nov 16, 2022 •
edited
Loading

Closes #2918 - "cbegin should always return a constant iterator".

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner November 16, 2022 15:44
@JMazurkiewicz JMazurkiewicz mentioned this pull request Nov 16, 2022
Closed
@StephanTLavavej StephanTLavavej added ranges C++20/23 ranges cxx23 C++23 feature labels Nov 16, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 16, 2022

Thanks, this is awesome! Just wanted to mention that most of the maintainers will be on vacation for Thanksgiving week in the US, but we'll review this when we get back. 😸

@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented Nov 19, 2022

And... it's an ICE 😤

@barcharcraz
Copy link
Contributor

barcharcraz commented Dec 1, 2022

Do you happen to have a reduced case for this ICE? If not don't worry about it, I'll reduce it and push a transition comment.

@JMazurkiewicz
Copy link
Contributor Author

JMazurkiewicz commented Dec 1, 2022

Do you happen to have a reduced case for this ICE?

Nope

@barcharcraz
Copy link
Contributor

barcharcraz commented Dec 2, 2022

Filed the frontend bug internally as VSO-1692469. I have not pushed a transition comment as I think the workaround improves the code anyway, so I don't think we need to come back to it when this bug is fixed.

barcharcraz
barcharcraz approved these changes Dec 7, 2022
View reviewed changes
@barcharcraz barcharcraz removed their assignment Dec 7, 2022
@StephanTLavavej StephanTLavavej self-assigned this Dec 7, 2022
StephanTLavavej
StephanTLavavej reviewed Dec 10, 2022
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Dec 10, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 10, 2022

Thanks, this looks fantastic! 😻 I pushed changes for 3 incredibly tiny nitpicks in the test code.

@StephanTLavavej StephanTLavavej self-assigned this Dec 15, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 15, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 032120d into microsoft:main Dec 15, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 15, 2022

Thanks for implementing this feature step-by-step, it was a pleasure to review! 😻 🎉 🚀

@JMazurkiewicz JMazurkiewicz deleted the as_const_view branch December 15, 2022 22:18
@StephanTLavavej StephanTLavavej mentioned this pull request Feb 12, 2023
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@barcharcraz barcharcraz barcharcraz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P2278R4 cbegin Should Always Return A Constant Iterator

4 participants

@JMazurkiewicz @StephanTLavavej @barcharcraz @CaseyCarter